Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash Fix Internet Connection Check On Item Click #13208

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Jun 28, 2024

  • Tests written, or not not needed

It checks mContainerActivity's nullability and type for the checking internet connection

Signed-off-by: alperozturk <[email protected]>
@alperozturk96 alperozturk96 linked an issue Jun 28, 2024 that may be closed by this pull request
Signed-off-by: alperozturk <[email protected]>
Copy link

Codacy

Lint

TypemasterPR
Warnings6363
Errors33

SpotBugs

CategoryBaseNew
Bad practice6464
Correctness6565
Dodgy code319316
Experimental11
Internationalization77
Multithreaded correctness66
Performance5555
Security1818
Total535532

Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13208.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@alperozturk96 alperozturk96 merged commit 56100de into master Jun 28, 2024
21 checks passed
@AndyScherzinger AndyScherzinger deleted the crash-fix-check-internet-connection branch June 28, 2024 14:09
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.30.0 milestone Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I just open the app
2 participants