Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note to get correct source IP when using rootless docker #4671

Merged
merged 2 commits into from
Jul 19, 2024
Merged

Add note to get correct source IP when using rootless docker #4671

merged 2 commits into from
Jul 19, 2024

Conversation

ccaccb
Copy link

@ccaccb ccaccb commented May 18, 2024

Fixes #4621

@szaimen
Copy link
Collaborator

szaimen commented May 21, 2024

Hi, thanks for the PR! :)

Would you mind fixing DCO? We need this so that we can merge your commit.

See
image

@szaimen szaimen added 3. to review Waiting for reviews documentation Improvements or additions to documentation labels May 21, 2024
@szaimen szaimen added this to the next milestone May 21, 2024
@szaimen szaimen modified the milestones: v8.3.0, next May 30, 2024
@szaimen szaimen modified the milestones: v9.0.0, next Jun 7, 2024
@ccaccb ccaccb force-pushed the feature/4621-docker-rootless-external-ip-documentation branch from 5f43bea to a96b2d6 Compare June 7, 2024 14:26
@ccaccb ccaccb force-pushed the feature/4621-docker-rootless-external-ip-documentation branch from a96b2d6 to 354c642 Compare June 7, 2024 14:27
@szaimen
Copy link
Collaborator

szaimen commented Jun 10, 2024

@Kirk1984 does this change look good to you? :)

@Kirk1984
Copy link

Sorry, i don't know. I have to confess that i ditched rootless a year+ ago for the time being. Some of my selfhosted services hat issues with it and from time to time the docker network died (around the 25+ container Mark). Never found the issue. I isolated my stuff in Proxmox VMs now.

@szaimen
Copy link
Collaborator

szaimen commented Jun 10, 2024

Sorry, i don't know. I have to confess that i ditched rootless a year+ ago for the time being. Some of my selfhosted services hat issues with it and from time to time the docker network died (around the 25+ container Mark). Never found the issue. I isolated my stuff in Proxmox VMs now.

I see. Thanks for the feedback!

@szaimen szaimen modified the milestone: next Jun 11, 2024
@szaimen szaimen added this to the next milestone Jul 1, 2024
@szaimen szaimen modified the milestones: v9.2.0, next Jul 11, 2024
@szaimen szaimen modified the milestones: v9.3.0, next Jul 19, 2024
@szaimen
adjust things a bit
ce6e941 
Signed-off-by: Simon L. <[email protected]>
szaimen
szaimen approved these changes Jul 19, 2024
View reviewed changes
Copy link
Collaborator

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@szaimen szaimen merged commit 07b603a into nextcloud:main Jul 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen approved these changes

Assignees
No one assigned
Labels
3. to review Waiting for reviews documentation Improvements or additions to documentation
Projects
None yet
Milestone
v9.4.0
3 participants
@ccaccb @szaimen @Kirk1984