Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added ESI options for contact form, #116, #486 #1471

Merged
merged 2 commits into from
Feb 26, 2018
Merged

added ESI options for contact form, #116, #486 #1471

merged 2 commits into from
Feb 26, 2018

Conversation

sprankhub
Copy link
Contributor

This ensures that no user data is stored in Varnish (the contact form is pre-filled with user data for logged in users).

@miguelbalparda
Copy link
Contributor

I'm trying to catch up with the PRs, can you point this to devel instead of master? Sorry for the delay!

@sprankhub sprankhub changed the base branch from master to devel January 30, 2018 15:15
@sprankhub
Copy link
Contributor Author

Thanks @miguelbalparda! Done.

@sprankhub
Copy link
Contributor Author

BTW: You may want to set the base branch of the repository to devel to have fewer PRs to master.

@sprankhub
Copy link
Contributor Author

It turned out that wholepunching the contactForm block was not enough. The form action was only post in this case and not the whole shop URL plus contacts/index/post. I now excluded the whole contacts page, which seems to work.

@miguelbalparda miguelbalparda merged commit 6dca656 into nexcess:devel Feb 26, 2018
@sprankhub sprankhub deleted the patch-1 branch February 26, 2018 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sprankhub @miguelbalparda