Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NR-120689] disable prometheus normalization feature-gate by default #57

Merged

Conversation

sigilioso
Copy link
Contributor

It disables the pkg.translator.prometheus.NormalizeName feature-gate by default.

Background information

The feature gate was enabled by default by reaching the beta state in otelcollector-contrib v0.76.3. When this feature-gate is enabled prometheus metrics names are renamed to match OTEL conventions in the prometheus receiver and we would like to avoid this behavior by default.

Additionally, there is an ongoing discussion to consider providing a configuration option (not a feature-gate) to disable the prometheus normalization: opentelemetry-collector-contrib#21743.

@sigilioso sigilioso requested a review from a team May 25, 2023 15:30
@sigilioso sigilioso changed the title NR-120689: disable prometheus normalization feature-gate by default [NR-120689] disable prometheus normalization feature-gate by default May 26, 2023
rogercoll
rogercoll previously approved these changes May 26, 2023
Copy link
Contributor

@rogercoll rogercoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Do you know if the idea (in the near future) is to remove this feature gate and be the default behavior?

@sigilioso
Copy link
Contributor Author

Great! Do you know if the idea (in the near future) is to remove this feature gate and be the default behavior?

The feature-gate is supposed to be eventually removed, therefore the default behavior would be the same as it is at the moment: having the prometheus normalization name enabled. However, since this change is quite disruptive and affects everyone using the prometheus receiver and not using one of the prometheus exporters, including a configuration option to disable prometheus normalization is being considered here.

It seems the feature-gate will be kept for a while, but when it is removed we will need to either rely on this configuration option (if its finally implemented) or take a different approach.

@rogercoll
Copy link
Contributor

Sounds good! Thanks for the explanation and links @sigilioso

Copy link
Contributor

@brushknight brushknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brushknight brushknight merged commit 436fdcb into main May 26, 2023
3 checks passed
@brushknight brushknight deleted the NR-120689-disable-prometheusName-normalization-by-default branch May 26, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants