Pass stop_timeout down to underlying http request #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When setting a custom stop_timeout, the value is passed to the docker API, but Excon won't wait any longer than 120 seconds for the response. This can lead to incorrect timeout errors if the container takes longer than that to stop. This passes the docker stop_timeout to the Excon request so it will wait at least as long as docker will for the container to stop.
relistan
added a commit
that referenced
this pull request
Jun 9, 2016
intjonathan
pushed a commit
that referenced
this pull request
Jan 13, 2017
Passing identical timeouts to Docker and the Excon client resulted in Excon giving up too soon when Docker was trying to kill timed-out containers. For example, you may set a docker stop timeout of 30, expecting your service to respond adequately to a KILL after 30 seconds. However, your deploy would stop immediately after the 30 second timeout because Excon would give up right away. This adds 120 seconds to the given stop timeout, then passes that to the Excon client. This should give the deploy plenty of time for Docker to do its business even on sad servers. Followup to #171
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting a custom stop_timeout, the value is passed to the docker API, but Excon won't wait any longer than 120 seconds for the response. This can lead to incorrect timeout errors if the container takes longer than that to stop.
This passes the docker stop_timeout to the Excon request so it will wait at least as long as docker will for the container to stop.