Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dcorr sqrt bug #385

Merged
merged 5 commits into from
Jun 20, 2023
Merged

fix dcorr sqrt bug #385

merged 5 commits into from
Jun 20, 2023

Conversation

sampan501
Copy link
Member

Reference issue

Closes #384

Type of change

Bug

What does this implement/fix?

Takes square root of Dcorr test statistic and fixes fast Dcorr so statistic is calculated as before.

Additional information

@netlify
Copy link

netlify bot commented Jun 20, 2023

Deploy Preview for hyppo ready!

Name Link
🔨 Latest commit fa377e5
🔍 Latest deploy log https://app.netlify.com/sites/hyppo/deploys/6491c71fd38fdf00082b5f08
😎 Deploy Preview https://deploy-preview-385--hyppo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (50f9c68) 96.70% compared to head (fa377e5) 96.71%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #385   +/-   ##
=======================================
  Coverage   96.70%   96.71%           
=======================================
  Files          86       86           
  Lines        3886     3891    +5     
=======================================
+ Hits         3758     3763    +5     
  Misses        128      128           
Impacted Files Coverage Δ
hyppo/independence/tests/test_kmerf.py 87.50% <ø> (ø)
hyppo/independence/tests/test_maxmargin.py 100.00% <ø> (ø)
hyppo/independence/dcorr.py 97.67% <100.00%> (ø)
hyppo/independence/tests/test_dcorr.py 100.00% <100.00%> (ø)
hyppo/ksample/tests/test_ksamp.py 100.00% <100.00%> (ø)
hyppo/tools/common.py 94.17% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sampan501 sampan501 merged commit 46f82a9 into main Jun 20, 2023
7 checks passed
@sampan501 sampan501 deleted the dcorr-stat-bug branch June 20, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fast DCORR results - different from regular DCORR results? [Question]
1 participant