-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add discriminability (one sample and two sample) #27
Conversation
Codecov Report
@@ Coverage Diff @@
## master #27 +/- ##
==========================================
- Coverage 94.97% 94.66% -0.32%
==========================================
Files 18 22 +4
Lines 717 862 +145
==========================================
+ Hits 681 816 +135
- Misses 36 46 +10
Continue to review full report at Codecov.
|
@jdey4 please add unit tests, code coverage is way to low |
@sampan501 added unit tests for oneSample test. |
I'd make the PR title more descriptive, even if this is a work in progress |
Also, far more unit tests are needed to maintain proper code coverage |
Try rerunning Travis to reset cache |
Deploy preview for mgc-new ready! Built with commit 2fd2f67 |
@jdey4 make sure you run black on all files to format them. More info can be found here: https://black.readthedocs.io/en/stable/ |
Codecov Report
@@ Coverage Diff @@
## master #27 +/- ##
=========================================
Coverage ? 85.47%
=========================================
Files ? 26
Lines ? 1012
Branches ? 0
=========================================
Hits ? 865
Misses ? 147
Partials ? 0
Continue to review full report at Codecov.
|
@sampan501 could you have a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly minor docs changes, 1 section with nested for loops can be compiled with numba.
@jdey4 Please add a link to the commit and line number under each comment of the review where the change has been made
@sampan501 I could not add Numba and it seems that it needs broadcasting a large argument with Numba if I write a function to do the looping. It may seriously increase runtime. |
That is simply not true. Numba is a jit-compiler and increases speed of nested for loops and numpy operations. See https://numba.pydata.org/numba-doc/latest/user/5minguide.html |
Also can you link where you addressed my comments in the commits? It is not clear at all based on the names of your commits |
Closes #13.
Added functionality for one sample test (@sampan501 ). This performs a one-sample test for whether the discriminability differs from random chance, as described in: https://www.biorxiv.org/content/10.1101/802629v1.full