Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename binnedBaseTern to something more general #272

Open
MrAE opened this issue May 22, 2019 · 2 comments
Open

rename binnedBaseTern to something more general #272

MrAE opened this issue May 22, 2019 · 2 comments

Comments

@MrAE
Copy link
Collaborator

MrAE commented May 22, 2019

As a quick-fix until we get a randMat class.
@jovo @falkben @jbrowne6
My suggestions (ranked) are:

  1. binnedBaseProjection
  2. binnedBaseRandMat
  3. binnedBaseWeighted
  4. binnedBaseCustom
@MrAE MrAE changed the title swap binnedBaseTern to something more general rename binnedBaseTern to something more general May 22, 2019
@jovo
Copy link
Member

jovo commented May 22, 2019 via email

@falkben
Copy link
Contributor

falkben commented Jun 6, 2019

i don't think we care what it's called in C++ as long as it's clear to us. binnedBaseTern seems fine to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants