Avoid including header values in header validation failure exceptions #12642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Exception messages may end up in logs, or other error reporting mechanisms, and we cannot necessarily tell at header validation time if the header value is sensitive information or not. Hence, it's better to not include it, and instead rely on the header name as a debugging aid. Modification: Remove the inclusion of the header value that fails header validation. And instead add the name of the header that fails validation. Result: If sensitive information fails header validation, it will no longer be exposed through the exception messages.
10595c5
to
ed2fc71
Compare
chrisvest
added a commit
that referenced
this pull request
Jul 27, 2022
…#12642) Motivation: Exception messages may end up in logs, or other error reporting mechanisms, and we cannot necessarily tell at header validation time if the header value is sensitive information or not. Hence, it's better to not include it, and instead rely on the header name as a debugging aid. Modification: Remove the inclusion of the header value that fails header validation. And instead add the name of the header that fails validation. Result: If sensitive information fails header validation, it will no longer be exposed through the exception messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Exception messages may end up in logs, or other error reporting mechanisms, and we cannot necessarily tell at header validation time if the header value is sensitive information or not.
Hence, it's better to not include it, and instead rely on the header name as a debugging aid.
Modification:
Remove the inclusion of the header value that fails header validation.
And instead add the name of the header that fails validation.
Result:
If sensitive information fails header validation, it will no longer be exposed through the exception messages.