Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Labels for LAGs between nodes now aligned with each link #53

Merged
merged 11 commits into from
May 21, 2023
Merged

Labels for LAGs between nodes now aligned with each link #53

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5d1ea49
GraphiteAlignedLabel using textPath
bortok May 20, 2023
449fb45
LinkWithAlignedLabels sourceView & targetView props
bortok May 20, 2023
53ad80d
moved sourceView/targetView to parent GraphiteLink
bortok May 20, 2023
489b0da
moved more to the parent class
bortok May 20, 2023
78715fa
fixed offsets with scaling
bortok May 20, 2023
491073d
refactor offset and add scaling gap
bortok May 20, 2023
7921df6
check for NaN offset/gap values
bortok May 21, 2023
9049541
indent
bortok May 21, 2023
bb439f6
refactor gap scaling
bortok May 21, 2023
c726581
moved target label under the link
bortok May 21, 2023
2ec4253
refactor gaps into source/targetGap
bortok May 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
moved sourceView/targetView to parent GraphiteLink
  • Loading branch information
@bortok
bortok committed May 20, 2023
commit 53ad80d4f6eee20a2db99c34b22cfb54963a2f78
60 changes: 28 additions & 32 deletions app/js/nextui.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,6 +543,34 @@
*/
nx.define('GraphiteLink', nx.graphic.Topology.Link, {
properties: {
sourceView: {
/**
* Get or set the source view
* @property sourceView
*/
get: function () {
return this.view('source');
},
set: function (value) {
if (value !== undefined && this._sourceView !== value) {
this.view('source', value);
}
}
},
targetView: {
/**
* Get or set the source view
* @property targetView
*/
get: function () {
return this.view('target');
},
set: function (value) {
if (value !== undefined && this.targetView !== value) {
this.view('target', value);
}
}
},
sourceName: {
get: function() {
return this.model().get("srcIfName");
Expand Down Expand Up @@ -660,38 +688,6 @@
*/
nx.define('LinkWithAlignedLabels', GraphiteLink, {
properties: {
sourceView: {
/**
* Get or set the source view
* @property sourceView
* @type {GraphiteAlignedLabel}
* @default null
*/
get: function () {
return this.view('source');
},
set: function (value) {
if (value !== undefined && this._sourceView !== value) {
this.view('source', value);
}
}
},
targetView: {
/**
* Get or set the source view
* @property targetView
* @type {GraphiteAlignedLabel}
* @default null
*/
get: function () {
return this.view('target');
},
set: function (value) {
if (value !== undefined && this.targetView !== value) {
this.view('target', value);
}
}
}
},
view: function(view) {
view.content.push({
Expand Down