Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent interface labels displaying upside-down. Prep for dynamic properties. #32

Merged
merged 22 commits into from
Jun 12, 2022
Merged

Prevent interface labels displaying upside-down. Prep for dynamic properties. #32

merged 22 commits into from
Jun 12, 2022

Conversation

bortok
Copy link
Contributor

@bortok bortok commented Jun 12, 2022

Interface label improvements:

  • Same color as node labels, follow display theme
  • Align opposite labels on the link to different sides of the link, to prevent overlapping on tighter diagrams
  • When interface labels are tracking rotation of their respective link and detect it is going beyond 90deg, they now automatically flip, thus preventing from being displayed upside-down.

Plus, prep work for displaying dynamic properties on nodes and links.

bortok added 22 commits May 8, 2022 19:23
@bortok
TopologyContainer instead of Topology
95d9b08 
see https://github.com/CiscoDevNet/opendaylight-sample-apps/tree/master/next-dynamic-topology
@bortok
actionbar with toggle asn test
4bd2a89
@bortok
AnnotatedNode class with status and ASN props
85bb70c
@bortok
Merge branch 'main' into node-update
db773da
@bortok
Merge branch 'main' into node-update
8df8497
@bortok
actionBar: toggle link label types
4ef6607
@bortok
move layout functions to TopologyApp
6560768
@bortok
devicePropsBadge
540fb26
@bortok
actionbar url param
07b37a6
@bortok
show only interface numbers
e7c4b8e
@bortok
link ip labels with static values
3a30bde
@bortok
link labels to use opposite baselines
e5a65d8
@bortok
flip ip labels
7c5dc9b
@bortok
use interface numbers only with BadgeLinkLabel
0064357
@bortok
flip for AlignedLinkLabel
7111735
@bortok
DRY AlignedLinkLabel BadgeLinkLabel
ccd6637
@bortok
load label IPs from host data
686c043
@bortok
BadgeLinkLabel getters for IP labels
721263a
@bortok
BadgeLinkLabel IP setters
eebbb4b
@bortok
BadgeLinkLabel hide IPs by default
8df5b2f
@bortok
LinkWithAlignedLabels refactor with view content
6aa1ea2
@bortok
Containerlab label
7063e55
@bortok bortok merged commit 366c08d into main Jun 12, 2022
@bortok bortok deleted the node-update branch June 12, 2022 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@bortok