Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow GitHub compare API #45

Merged
merged 1 commit into from
Jan 8, 2020

Conversation

erezrokah
Copy link
Contributor

Due to a recent change in Netlify CMS, we are using the GitHub compare API to rebase branches.

Not sure how to go about testing it locally.

@mraerino
Copy link
Member

mraerino commented Jan 8, 2020

I can provide you with a staging deployment of this PR. Would that help?

@erezrokah
Copy link
Contributor Author

That would be perfect

@erezrokah
Copy link
Contributor Author

erezrokah commented Jan 8, 2020

I tried running the git-gateway binary after building it locally, but not sure how to set up the environment variables to get pass authentication

@mraerino
Copy link
Member

mraerino commented Jan 8, 2020

Copy link
Member

@mraerino mraerino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Verified on staging.

@mraerino mraerino merged commit 8361c93 into netlify:master Jan 8, 2020
@erezrokah erezrokah deleted the feat/allow_github_compare_api branch January 8, 2020 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants