Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Netlify Dev: Add framework = "#custom" option #843

Merged
merged 34 commits into from
May 4, 2020
Merged

Netlify Dev: Add framework = "#custom" option #843

Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
19f0def
Add framework = "#custom" option
RaeesBhatti Apr 18, 2020
57e3827
Error if framework not #custom but command and targetPort
RaeesBhatti Apr 18, 2020
a8990ac
Grammar
RaeesBhatti Apr 18, 2020
c98e182
Improve static server settings
RaeesBhatti Apr 18, 2020
64ce2b1
Throw more errors :bangbang:
RaeesBhatti Apr 18, 2020
24861b6
Grammar
RaeesBhatti Apr 18, 2020
a144e16
Improve static server log
RaeesBhatti Apr 18, 2020
b9d659a
devConfig: Get publish directory from build as well
RaeesBhatti Apr 18, 2020
bc25c29
Dev: Pass site.root to serverSettings
RaeesBhatti Apr 18, 2020
66a3dd2
Fix tests
RaeesBhatti Apr 18, 2020
70bcc96
Add new test for no config
RaeesBhatti Apr 18, 2020
8cd1bbd
Move tests out of src
RaeesBhatti Apr 28, 2020
02e675b
Dev test: Always cleanup
RaeesBhatti Apr 28, 2020
0ed39e1
isStatic: Fix a loop mistake 🤦🏽‍♂️
RaeesBhatti Apr 28, 2020
9b3cc71
Dev: Fix force behavior on redirects
RaeesBhatti Apr 28, 2020
3e1a25f
Add tests for create-react-app
RaeesBhatti Apr 28, 2020
fff718c
Merge branch 'master' into raees/dev-config-improvements
RaeesBhatti Apr 28, 2020
33e94da
Fix tests
RaeesBhatti Apr 28, 2020
ab774e8
Fix a bug in framework name
RaeesBhatti Apr 28, 2020
e02da24
Apply settings from framework
RaeesBhatti Apr 28, 2020
9524ddd
Add test for create-react-app framework option
RaeesBhatti Apr 29, 2020
2c41e5a
GH Actions: Install cra dependencies
RaeesBhatti Apr 29, 2020
28ff595
Use yarn for cra
RaeesBhatti Apr 29, 2020
2d4b6f9
Build tests: Fix bin path
RaeesBhatti Apr 29, 2020
654f83a
Tests: Use random ports
RaeesBhatti Apr 29, 2020
10b1e2d
Test: Add framework to netlify.toml
RaeesBhatti Apr 29, 2020
e365a24
Random port util
RaeesBhatti Apr 29, 2020
4b8f707
Whitespace
RaeesBhatti Apr 29, 2020
7fe6119
Change famework properties to match file names
RaeesBhatti May 3, 2020
b3f42af
Detect Server: Fix command for npm
RaeesBhatti May 3, 2020
7a07206
Fix tests
RaeesBhatti May 4, 2020
13f8808
Detect Server: Better error log
RaeesBhatti May 4, 2020
3b1e1db
Improve docs
RaeesBhatti May 4, 2020
ba3cbec
Move npm command logic up
RaeesBhatti May 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Build tests: Fix bin path
  • Loading branch information
@RaeesBhatti
RaeesBhatti committed Apr 29, 2020
commit 2d4b6f9096831f9c1aafb09c5c6838757fcebf67
3 changes: 2 additions & 1 deletion tests/build.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
const path = require('path')
const test = require('ava')
const execa = require('execa')

const BIN_PATH = `${__dirname}/../../bin/run`
const BIN_PATH = path.join(__dirname, '..', 'bin', 'run')
const FIXTURE_DIR = __dirname

// Runs `netlify build ...flags` then verify:
Expand Down