chore: site builder should infer directory name from tests #6274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skn0tt
changed the title
📊 Benchmark resultsComparing with 5d6bcf3
|
lukasholzer
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of our tests use
withSiteBuilder. I noticed that on Windows, we're seeing a lot of "Resource Busy or locked" exceptions when the site builder tries to clean up the directory it created. The resources are "busy", because we re-used the same sitename between a lot of our tests, so they ended up using the same directories - possibly a race condition. I'm assuming this comes from copy&paste.This PR adds a new signature to
withSiteBuilderthat infers the site name based on the test name. Since we always adapt test names, this should work way better! Some of the usage i've already transitioned. To encourage folks to transition the rest as well, i've marked the old signature as deprecated.