Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): change port to targetPort when framework is #custom #1573

Merged
merged 1 commit into from
Nov 19, 2020

Conversation

erezrokah
Copy link
Contributor

Fixes the docs to match https://github.com/netlify/cli/blame/master/docs/netlify-dev.md#L151,

throw new Error('"command" and "targetPort" properties are required when "framework" is set to "#custom"')
,
'"framework" option must be set to "#custom" when specifying both "command" and "targetPort" options',
and #843 (comment)

@erezrokah erezrokah requested a review from a team as a code owner November 19, 2020 12:42
@github-actions github-actions bot added the type: bug code to address defects in shipped code label Nov 19, 2020
@erezrokah erezrokah merged commit 301a9f1 into master Nov 19, 2020
@erezrokah erezrokah deleted the fix/docs_netlify_dev_port branch November 19, 2020 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants