Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .editorconfig #1435

Merged
merged 1 commit into from
Oct 21, 2020
Merged

Add .editorconfig #1435

merged 1 commit into from
Oct 21, 2020

Conversation

ehmicky
Copy link
Contributor

@ehmicky ehmicky commented Oct 16, 2020

This adds an .editorconfig file.

@ehmicky ehmicky added the type: chore work needed to keep the product and development running smoothly label Oct 16, 2020
@ehmicky ehmicky requested a review from a team as a code owner October 16, 2020 18:44
@ehmicky ehmicky self-assigned this Oct 16, 2020
Copy link
Contributor

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can set options.editorconfig to true in .prettierrc.json and remove the printWidth setting from it, WDYT?
See https://prettier.io/docs/en/api.html#prettierresolveconfigfilepath--options

@ehmicky
Copy link
Contributor Author

ehmicky commented Oct 21, 2020

Good point! I have just removed the redundant Prettier option printWidth.
The editorconfig option in Prettier is true by default, so we don't need to explicitly enable it (I have just tried it locally to make sure).

@ehmicky ehmicky merged commit b91ef34 into master Oct 21, 2020
@ehmicky ehmicky deleted the chore/add-editorconfig branch October 21, 2020 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: chore work needed to keep the product and development running smoothly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants