Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alternative mode for System Rescue with 'rootpass' as MAC address #1471

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

antonym
Copy link
Member

@antonym antonym commented Jun 4, 2024

Related to #1441

Adds a new menu entry to the System Rescue CD Tools menu in roles/netbootxyz/templates/menu/systemrescue.ipxe.j2 to enable setting the 'rootpass' boot parameter to the device's MAC address.

  • New Menu Entry: Introduces an option labeled "Enable rootpass=MAC_ADDRESS" that allows users to set the 'rootpass' boot parameter to their device's MAC address for easier access.
  • Toggle Functionality: Implements a toggle mechanism that enables or disables the 'rootpass' parameter based on the user's selection from the menu. This is achieved through a conditional check that sets or unsets the rootpass_enabled flag and the params variable accordingly.
  • Dynamic Parameter Setting: Modifies the boot command to dynamically include the rootpass parameter with the MAC address value when the option is enabled by the user.

For more details, open the Copilot Workspace session.

@antonym antonym merged commit a39b99d into development Jun 4, 2024
2 checks passed
@antonym antonym deleted the antonym/add-mac-pass-1 branch June 4, 2024 02:23
@lars18th
Copy link

Hi @antonym ,

Thank you for incorporating my idea suggested in #1440 .

However, the current implementation prints in the screen menu Enable rootpass=MAC_ADDRESS. While the idea is to print the current MAC address: Enable rootpass=00aabbcc1122. You can check my original dirty implementation in https://github.com/lars18th/netboot.xyz-custom/blob/master/custom.ipxe

This has sense because with multiple NICs the MAC ADDRESS could not be clear.

I hope you will want to improve this.
Regards.

@lars18th
Copy link

lars18th commented Jul 8, 2024

ping @antonym

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants