mpv: whitelist /usr/share/mpv #6128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmk3
changed the title
Use case: You install scripts in `/usr/share/mpv` but they remain inactive. You then symlink them to `/etc/mpv` to activate them if you want.
kmk3
approved these changes
Dec 14, 2023
|
Added some missing paths and force-pushed.
Good catch; I'll fix that after this PR. |
|
Merged! |
kmk3
added a commit
to kmk3/firejail
that referenced
this pull request
Jan 6, 2024
To ensure that it includes luajit paths as well: * /usr/share/lua * /usr/share/luajit-2.1 And remove all entries of the same path without the wildcard, to avoid redundancy. Misc: The wildcard entries were added on commit 56b60df ("additional Lua blacklisting (netblue30#3246)", 2020-02-24) and the entries without the wildcard were partially removed on commit 721a984 ("Fix Lua in disable-interpreters.inc", 2020-02-24). This is a follow-up to netblue30#6128. Reported-by: @pirate486743186
kmk3
added a commit
that referenced
this pull request
Jan 8, 2024
To ensure that it includes luajit paths as well: * /usr/share/lua * /usr/share/luajit-2.1 And remove all entries of the same path without the wildcard, to avoid redundancy. Misc: The wildcard entries were added on commit 56b60df ("additional Lua blacklisting (#3246)", 2020-02-24) and the entries without the wildcard were partially removed on commit 721a984 ("Fix Lua in disable-interpreters.inc", 2020-02-24). This is a follow-up to #6128. Reported-by: @pirate486743186
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use case, you install scripts in
/usr/share/mpvbut they remain inactive. You then symlnk them to/etc/mpvto activate them if you want.Question, isn't
whitelist /usr/share/luaredundant because ofwhitelist /usr/share/lua*?