minecraft-launcher.profile: allow keyring access #6118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glitsj16
reviewed
Dec 7, 2023
glitsj16
requested changes
Dec 7, 2023
glitsj16
approved these changes
Dec 8, 2023
|
I wonder if adding an |
Great idea. We have other include files that aren't used by a huge amount of profiles. Feel free to implement! |
|
All merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out it is using it to save logins and will error out with just a generic "something went wrong, so we can not save your login".
I copied the directives from email-common.inc. Unsure which specific dbus topic thingy is actually used here but it works and I think it is fine to leave all 3.
Dear maintainers, if the ordering of the directives, my arch nemesis, is wrong, please apply your suggestion or edit without asking.