ci: re-enable sort.py #6104
Merged
ci: re-enable sort.py #6104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was disabled on commit df6ea88 ("merges, disable sort.py in profile checks temporarely, two more private-etc profiles", 2023-02-14). Currently all profiles are sorted and there are no ongoing `private-etc` changes, so it should be safe to re-enable. Note that the script is useful to catch sorting issues not only in `private-etc` but also in other commands, such as `seccomp`[1] [2]. This is a follow-up to netblue30#6070. Relates to netblue30#5610. [1] netblue30#6066 (comment) [2] netblue30#6067 (comment)
kmk3
force-pushed
the
ci-enable-sort-py
branch
from
7a48de2
to
78bbcb7
Compare
|
merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was disabled on commit df6ea88 ("merges, disable sort.py in profile
checks temporarely, two more private-etc profiles", 2023-02-14).
Currently all profiles are sorted and there are no ongoing
private-etcchanges, so it should be safe to re-enable.
Note that the script is useful to catch sorting issues not only in
private-etcbut also in other commands, such asseccomp[1] [2].This is a follow-up to #6070.
Relates to #5610.
[1] #6066 (comment)
[2] #6067 (comment)