Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

man: mention that the protocol command accumulates #5043

Merged
merged 1 commit into from
Mar 24, 2022

Conversation

kmk3
Copy link
Collaborator

@kmk3 kmk3 commented Mar 13, 2022

As mentioned by @rusty-snake[1].

This amends commit 39654d0 ("adding netlink to --protocol list
(#4605)", 2022-01-21).

See also commit 75073e0 ("man: mention that private-bin and
private-etc are cumulative", 2022-01-22) and issue #4078.

[1] https://github.com/netblue30/firejail/pull/5042/files#r825477891

As mentioned by @rusty-snake[1].

This amends commit 39654d0 ("adding netlink to --protocol list
(netblue30#4605)", 2022-01-21).

See also commit 75073e0 ("man: mention that private-bin and
private-etc are cumulative", 2022-01-22) and issue netblue30#4078.

[1] https://github.com/netblue30/firejail/pull/5042/files#r825477891
@kmk3 kmk3 added the documentation Issues and pull requests related to the documentation label Mar 13, 2022
@kmk3 kmk3 added this to In progress in Release 0.9.70 via automation Mar 13, 2022
@rusty-snake
Copy link
Collaborator

See also

* --protocol now accumulates

5ffd928


Maybe we also want to add this to the manpage

/* Comma separated list is processed so that:
* "item" -> adds item to list
* "-item" -> removes item from list
* "+item" -> adds item to list
* "=item" -> clear list, add item

Copy link
Collaborator

@glitsj16 glitsj16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. IMO we should add @rusty-snake's #5043 (comment) too.

@kmk3
Copy link
Collaborator Author

kmk3 commented Mar 14, 2022

@rusty-snake commented on Mar 13:

See also

* --protocol now accumulates

5ffd928

+1

Maybe we also want to add this to the manpage

/* Comma separated list is processed so that:
* "item" -> adds item to list
* "-item" -> removes item from list
* "+item" -> adds item to list
* "=item" -> clear list, add item

I have some reservations and an alternative suggestion regarding this feature,
but it's rather lengthy, so I'll put it in a discussion later.

Copy link
Collaborator

@glitsj16 glitsj16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glitsj16
Copy link
Collaborator

I have some reservations and an alternative suggestion regarding this feature,
but it's rather lengthy, so I'll put it in a discussion later.

That's fine. I had forgotten about this +, -, = format. We'll pick it up in discussion later :-)

@netblue30
Copy link
Owner

Merging in, opened a new issue for list accumulation: #5070

@netblue30 netblue30 merged commit d127692 into netblue30:master Mar 24, 2022
@kmk3 kmk3 deleted the docs-protocol-acc branch March 24, 2022 15:12
kmk3 added a commit that referenced this pull request Mar 24, 2022
@kmk3 kmk3 moved this from In progress to Done (on RELNOTES) in Release 0.9.70 Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues and pull requests related to the documentation
Projects
No open projects
Release 0.9.70
  
Done (on RELNOTES)
Development

Successfully merging this pull request may close these issues.

None yet

4 participants