Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firejail.config: add warning about allow-tray #4946

Merged
merged 1 commit into from
Feb 20, 2022

Conversation

kmk3
Copy link
Collaborator

@kmk3 kmk3 commented Feb 15, 2022

According to #4053, there is currently no safe (in the sense of not
allowing to escape the sandbox) implementation of
org.kde.StatusNotifierWatcher, but it is required by multiple programs
for tray functionality. Users may not be aware of this (for example,
see #4508), so add a warning about it.

Note: allow-tray was added on commit c86cae2 ("Add new condition
ALLOW_TRAY", 2021-09-04) / PR #4510.

Cc: @davidebeatrici

@kmk3 kmk3 added the documentation Issues and pull requests related to the documentation label Feb 15, 2022
Copy link
Collaborator

@rusty-snake rusty-snake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dbus-user.talk org.kde.StatusNotifierWatcher is
unsafe and allows escaping the sandbox

In theory it could be safe, but I'm not aware of a safe implementation.

The unsafer thing with tray icons is dbus-user.own org.kde.*.

WARNING: allows escaping the sandbox;

How cares? There are enough other ways to escape. Anyway let's add it.

see https://github.com/netblue30/firejail/discussions/4053

Do we need the link? IMHO there isn't much information other than "it's unsafe!!!".

According to netblue30#4053, there is currently no safe (in the sense of not
allowing to escape the sandbox) implementation of
`org.kde.StatusNotifierWatcher`, but it is required by multiple programs
for tray functionality.  Users may not be aware of this (for example,
see netblue30#4508), so add a warning about it.

Note: allow-tray was added on commit c86cae2 ("Add new condition
ALLOW_TRAY", 2021-09-04) / PR netblue30#4510.
@kmk3
Copy link
Collaborator Author

kmk3 commented Feb 16, 2022

@rusty-snake left a comment:

dbus-user.talk org.kde.StatusNotifierWatcher is
unsafe and allows escaping the sandbox

In theory it could be safe, but I'm not aware of a safe implementation.

The unsafer thing with tray icons is dbus-user.own org.kde.*.

Reworded it (and made the warning lowercase).

Does it make sense now? Also, what are the implementations of
org.kde.StatusNotifierWatcher that you have in mind?

WARNING: allows escaping the sandbox;

How cares? There are enough other ways to escape. Anyway let's add it.

Users can only choose to care if they know about it. I think it would be
useful to document every common case of sandbox escaping (such as with #4760).

see https://github.com/netblue30/firejail/discussions/4053

Do we need the link? IMHO there isn't much information other than "it's
unsafe!!!".

I don't know much about the details, so to me it's much more information than
nothing. It also centralizes the discussion and the link might help attract
someone who would care enough to fix the implementation. But if you know of a
better resource we could use that instead.

@rusty-snake
Copy link
Collaborator

Also, what are the implementations of
org.kde.StatusNotifierWatcher that you have in mind?

IIRC I tested the native kde implementation, gnome-shell-extension-appindicator and the xfce implementation.

@netblue30 netblue30 merged commit 33a2609 into netblue30:master Feb 20, 2022
@kmk3 kmk3 deleted the add-warn-allow-tray branch February 20, 2022 15:19
@kmk3 kmk3 added this to In progress in Release 0.9.70 via automation Feb 20, 2022
kmk3 added a commit that referenced this pull request Mar 9, 2022
@kmk3 kmk3 moved this from In progress to Done (on RELNOTES) in Release 0.9.70 Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues and pull requests related to the documentation
Projects
No open projects
Release 0.9.70
  
Done (on RELNOTES)
Development

Successfully merging this pull request may close these issues.

None yet

3 participants