add notable profile #4824
Merged
add notable profile #4824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rusty-snake
reviewed
Jan 5, 2022
Comment on lines
+32
to
+34
| ignore include whitelist-runuser-common.inc | ||
| ignore include whitelist-usr-share-common.inc | ||
| ignore include whitelist-var-common.inc |
There was a problem hiding this comment.
Even for wruc, wusc, wvc?
There was a problem hiding this comment.
Yep, even those set notable into a fit and it always resets some internal pref so users are faced with a nagging screen on each invocation to select the main data dir (which is ${HOME}/.notable by default). I've tried to make it a whitelisting profile but didn't succeed. Closed-source app...
@rusty-snake What do you think, should we merge as-is?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion here.