Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add notable profile #4824

Merged
merged 4 commits into from
Jan 5, 2022
Merged

add notable profile #4824

merged 4 commits into from
Jan 5, 2022

Conversation

glitsj16
Copy link
Collaborator

@glitsj16 glitsj16 commented Jan 5, 2022

See discussion here.

Comment on lines +32 to +34
ignore include whitelist-runuser-common.inc
ignore include whitelist-usr-share-common.inc
ignore include whitelist-var-common.inc
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even for wruc, wusc, wvc?

Copy link
Collaborator Author

@glitsj16 glitsj16 Jan 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, even those set notable into a fit and it always resets some internal pref so users are faced with a nagging screen on each invocation to select the main data dir (which is ${HOME}/.notable by default). I've tried to make it a whitelisting profile but didn't succeed. Closed-source app...

@rusty-snake What do you think, should we merge as-is?

@glitsj16 glitsj16 merged commit 341f587 into netblue30:master Jan 5, 2022
@glitsj16 glitsj16 deleted the notable branch January 5, 2022 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants