skypeforlinux: Whitelist downloads directory #4807
Merged
+0
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's used when saving files send in conversations.
rusty-snake
approved these changes
Dec 30, 2021
| @@ -6,7 +6,6 @@ include skypeforlinux.local | |||
| include globals.local | |||
|
|
|||
| # Disabled until someone reported positive feedback | |||
| ignore whitelist ${DOWNLOADS} | |||
| ignore include whitelist-common.inc | |||
There was a problem hiding this comment.
We should remove this too.
There was a problem hiding this comment.
whitelist-common.inc grants write access to .config/dconf, and this sounds like it could be abused to run arbitrary commands (for example, by changing the default terminal).
There was a problem hiding this comment.
firejail/etc/inc/disable-common.inc
Line 155 in facf03c
- Who cares about such hacks for a profile which allows
systemd-run& co.
|
Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The downloads directory is used by skype to download files send by other parties.