yt-dlp: add missing paths & mpv.profile: whitelist paths for yt-dlp #4755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This amends commit d6ca41c ("update mpv.profile", 2021-10-24) / PR netblue30#4634. These paths were taken from yt-dlp(1). They are used since yt-dlp commit e2e43aea2 ("Portable Configuration file (closes #19)", 2021-01-16)[1]. Environment: yt-dlp 2021.12.01-1 on Artix Linux. Relates to: yt-dlp/yt-dlp#19 [1] yt-dlp/yt-dlp@e2e43ae
If it does not already exist, mpv is unlikely to need or to create it, so just whitelist it if it exists. This amends commit 5d74179 ("Use whitelisting for video players (netblue30#3472)", 2020-08-15).
See etc/profile-m-z/yt-dlp.profile. Relates to commit d6ca41c ("update mpv.profile", 2021-10-24) / PR netblue30#4634. Fixes netblue30#4754.
rusty-snake
approved these changes
Dec 9, 2021
There was a problem hiding this comment.
Probably there are some more:
$ grep -l 'noblacklist ${HOME}/.config/youtube-dl' /etc/firejail/*.profile
/etc/firejail/celluloid.profile
/etc/firejail/firefox-common-addons.profile
/etc/firejail/mpsyt.profile
/etc/firejail/mpv.profile
/etc/firejail/smplayer.profile
/etc/firejail/youtube-dl-gui.profile
/etc/firejail/youtube-dl.profile
Indeed; I'll change those on a new PR. By the way, does any of those programs create/modify youtube-dl/yt-dlp config? I think maybe only youtube-dl-gui would do so. If we can be reasonably sure that they don't, more |
|
merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4754.
Relates to #3472, #4634 and yt-dlp/yt-dlp#19.
Cc: @Fred-Barclay @NetSysFire @pirate486743186