Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "allow/deny fbuilder" #4593

Merged
merged 2 commits into from
Oct 9, 2021

Conversation

kmk3
Copy link
Collaborator

@kmk3 kmk3 commented Oct 5, 2021

This reverts commit 4438f14.

Also, partially revert related commit e4307b4 ("fix whitelist/allow in
make test-utils") to keep the tests working.

The profiles are being generated using aliases, which are not used on
the profiles in the repository. So generate them using the normal
commands for consistency. See also commit dd13595 ("Revert
"allow/deny help and man pages"") / PR #4502.

Relates to #4410.

Misc: I noticed this on issue #4592.

Added on commit 9af2c14 ("Better debug handling.").
This reverts commit 4438f14.

Also, partially revert related commit e4307b4 ("fix whitelist/allow in
make test-utils") to keep the tests working.

The profiles are being generated using aliases, which are not used on
the profiles in the repository.  So generate them using the normal
commands for consistency.  See also commit dd13595 ("Revert
"allow/deny help and man pages"") / PR netblue30#4502.

Relates to netblue30#4410.

Misc: I noticed this on issue netblue30#4592.
@kmk3 kmk3 force-pushed the revert-allow-deny-fbuilder branch from 3c89c50 to a7e4b9b Compare October 6, 2021 18:37
@kmk3
Copy link
Collaborator Author

kmk3 commented Oct 6, 2021

Force-push changes: Improve commit message.

@netblue30
Copy link
Owner

All in! I'll go through the test system and clean it up. Thanks!

@netblue30 netblue30 merged commit 2828b64 into netblue30:master Oct 9, 2021
@kmk3 kmk3 deleted the revert-allow-deny-fbuilder branch October 9, 2021 17:59
@kmk3 kmk3 added this to Done (RELNOTES N/A) in Release 0.9.68 Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Release 0.9.68
  
Done (RELNOTES N/A)
Development

Successfully merging this pull request may close these issues.

None yet

2 participants