WIP: Minor cleanup

[a1346054]

No description provided.

[rusty-snake]

Just an idea, maybe with a fall-back substitution.

Suggested change

	TOP=$(pwd)
	TOP=$PWD

[kmk3]

Minor cleanup

I wouldn't exactly call this minor; there are many unrelated changes in this
PR.

Some commits seem alright on their own, others I'm not so sure.

Anyway, I'd just like to leave a "please don't merge" in here for now until I
can review it properly.

[a1346054]

Rebased to fix merge conflicts.

[kmk3]

Sorry for the delay.

• use license file from gnu.org

LGTM; bonus points for catching a violation of the GPL license itself (I hadn't
seen this one before).

• fix missing newlines at end of files

LGTM.

I'd personally avoid doing this until there is a commit hook/CI check to detect
such things, but it does not change too many files, so sure.

By the way, what commands have you used to detect/fix this?

• fix spelling

Please either wait for the merge of #4502 (which conflicts with this) so that
it can be a clean revert or make a separate PR for this.

As for the commit itself, there are some leftovers:

$ git grep temporarely
configure:# overlayfs features temporarely disabled pending fixes
$ git grep parrent
src/firejail/usage.c:   "\tparrent interfaces.\n"

I have noticed the "parrent" one myself as well on #4502, though it was because
of the above file rather than the zsh completion.

Other than that, LGTM.

• fix shellcheck warnings

NAK; there are still many shellcheck warnings if you run it locally, including
for some common pitfalls, such as the lack of quotes.

Please make a separate PR for this.

• trim excess whitespace

I have some questions and I'd like to discuss this one separately.

Please make a separate PR for this.

[a1346054]

Thank you for the review, I will rework the PRs.

[rusty-snake]

@a1346054 can we close this PR?

[a1346054]

I reworked this PR and split it into individual PRs for further discussion, as suggested in the review comments.