Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Zoom profile for meeting recordings #4290

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

squatched
Copy link

By default, Zoom records meetings to ${HOME}/Documents/Zoom. Add that
folder to the whitelist so that future users don't lose their meeting
recordings upon shutting Zoom down.

That was a painful loss for me today =(.

By default, Zoom records meetings to ${HOME}/Documents/Zoom. Add that
folder to the whitelist so that future users don't lose their meeting
recordings upon shutting Zoom down.
Copy link
Collaborator

@rusty-snake rusty-snake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#4006

The problem is that "Documents" can also be "Dokumente", "Dokumenty", "Dokumentuak", "文档", "Документы", ... so whitelist ${DOCUMENTS} must be used instead [As you already discovered]. This has the drawback that ${DOCUMENTS}/Zoom is treated literally, so zoom has full access to ~/Documents.

I'm not sure if we want to give zoom this wide rights by default. Maybe we should add a comment that says what needs to be added to zoom.local to make meeting-recodring/notes-saving work.

cc @VorpalBlade

@rusty-snake rusty-snake linked an issue May 20, 2021 that may be closed by this pull request
6 tasks
@squatched
Copy link
Author

squatched commented May 26, 2021

Thank you for the feedback, I feel dumb for not thinking of localization but, c'est la vie.

Regardless, if there's any way I can help bottom-out on this issue, I'd love to do it because this REALLY hurt when it happened and I'd like to help others avoid the pain-point. I'm also fairly new to firejail and am only recently really digging into what it's capable of and tweaking it to my needs so, if you're willing to help me understand, I'm super happy to help out.

Also, if this would be better suited to a bug report, I'll close this pull request then open one.

The first issue I'm running into is Error: "${DOCUMENTS}/Zoom" is an invalid filename: rejected character: "{" when I try and use ${DOCUMENTS} instead of ${HOME}\Documents (even with the DOCUMENTS environment variable exported explicitly and the given folder already created, I'm running Arch and my firejail version is 0.9.64.4 from the community repo).

The second issue is... well... I'm just not sure how to accomplish the appropriate whitelisting here. I completely agree that we don't want to give Zoom access to the documents folder at large by default so... Advice is greatly appreciated.

@rusty-snake
Copy link
Collaborator

The first issue I'm running into is Error: "${DOCUMENTS}/Zoom" is an invalid filename: rejected character: "{" when I try and use ${DOCUMENTS}

That's what I mean with "This has the drawback that ${DOCUMENTS}/Zoom is treated literally".
Issues for it: #2359 (already linked in #4006).

even with the DOCUMENTS environment variable exporte

The ${DOCUMENTS} macro expands to XDG_DOCUMENTS_DIR in ~/.config/user-dirs.dirs or hardcoded defaults.

Also, if this would be better suited to a bug report, I'll close this pull request then open one.

We have issues for both ${DOCUMENTS}/foobar and Documents/Zoom. No need.

The second issue is... well... I'm just not sure how to accomplish the appropriate whitelisting here. I completely agree that we don't want to give Zoom access to the documents folder at large by default so... Advice is greatly appreciated.

Unless someone adds support for ${DOCUMENTS}/Zoom, we need to use whitelist ${DOCUMENTS} if we want to have it working by default.

@squatched
Copy link
Author

OK, thank you for the clarification. Super appreciate it.

I'll adjust this pull request to be just comments in the config that indicate what can happen and how to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zoom fails to save chat logs when executing under firejail
2 participants