Node.js stack refactoring #4255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rusty-snake
reviewed
May 7, 2021
Comment on lines
+16
to
+19
| ignore read-only ${HOME}/.npm-packages | ||
| ignore read-only ${HOME}/.npmrc | ||
| ignore read-only ${HOME}/.nvm | ||
| ignore read-only ${HOME}/.yarnrc |
There was a problem hiding this comment.
Maybe prefer read-write? IDK
There was a problem hiding this comment.
Maybe prefer
read-write? IDK
I agree that read-write sounds a lot more logical than the ignore blah construct. Just checked and I used it in git-cola, gnome-{logs,system-log} and yelp too apparently. Can't remember why OTOH but I'll change it after testing it gives the same result. That'll be over the weekend though, I'm clocking off for today. Thanks for the suggestions, much appreciated. And enjoy the weekend!
There was a problem hiding this comment.
FWIW: The only case where ignore read-only should be used instead of read-write are redirect profiles [and .locals] IMHO.
node-gyp is a shell script with a node shebang. We've got that covered via node.profile.
npx is a shell script with a node shebang. We've got that covered via node.profile.
semver is a shell script that calls node. We've got that covered via node.profile.
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to bring some sanity to our node.js related profiles. Based on info gathered from:
Not being a Node developer I'm marking this as WIP for now.I've been testing this, but the node stack still has many dark spots for me to unravel. Would be great if this could be more thoroughly tested. Open to all suggestions, input etcetera.IMPORTANT NOTE: none of the Node.js stack profiles are in firecfg. It is up to the user to create the necessary scripts/symlinks to sandbox the following commands: