Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename chromium-common-hardened and feh-network … #4126

Merged
merged 1 commit into from
Mar 24, 2021

Conversation

rusty-snake
Copy link
Collaborator

…again

I am still not really happy about the rename from #4028, #4029, #4030
and #4031. I've no problem with moving away .inc but I don't like the
result. So here's a proposal to make this better:

NAME DESCRIPTION
*-addons.profile (include) Allow external addons
*-common.profile (include) Common parts across multiple profiles
*-hardened.inc.profile Further hardening which can not be made default
*-network.inc.profile Allow optional network access
*-whitelist.inc.profile Enabled whitelisting (which can not be made default) ¹
*.inc.profile Other profile specific includes
*.profile A profile for a program
allow-*.inc Multiple noblacklists that should always be used together
disable-*.inc blacklisting
whitelist-*-common.inc common whitelists
*.inc Other generic includes
globals.local User overrides for all profiles
*.local Per profile user overrides

¹ can be used for programs like KeePassXC or editors.

…again

I am still not really happy about the rename from netblue30#4028, netblue30#4029, netblue30#4030
and netblue30#4031. I've no problem with moving away .inc but I don't like the
result. So here's a proposal to make this better:

| NAME                      | DESCRIPTION                                                  |
| ------------------------- | ------------------------------------------------------------ |
| `*-addons.profile`        | (include) Allow external addons                              |
| `*-common.profile`        | (include) Common parts across multiple profiles              |
| `*-hardened.inc.profile`  | Further hardening which can not be made default              |
| `*-network.inc.profile`   | Allow optional network access                                |
| `*-whitelist.inc.profile` | Enabled whitelisting (which can not be made default) ¹       |
| `*.inc.profile`           | Other profile specific includes                              |
| `*.profile`               | A profile for a program                                      |
| `allow-*.inc`             | Multiple `noblacklist`s  that should always be used together |
| `disable-*.inc`           | `blacklist`ing                                               |
| `whitelist-*-common.inc`  | common `whitelist`s                                          |
| `*.inc`                   | Other generic includes                                       |
| `globals.local`           | User overrides for all profiles                              |
| `*.local`                 | Per profile user overrides                                   |

¹ can be used for programs like KeePassXC or editors.
Copy link
Collaborator

@glitsj16 glitsj16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I for one like this proposal. Very clear logic behind the naming scheme while catering to concerns of package maintainers like @reinerh IMO. Full marks!

@reinerh
Copy link
Collaborator

reinerh commented Mar 21, 2021

I also like the proposal, though I find the .inc.profile extension a bit ugly.

Why did you keep *-addons and *-common with .profile extension only (and not .inc.profile)?

@rusty-snake
Copy link
Collaborator Author

*-addons.profile: good question
*-common.profile: I don't wanted even more .local renames.

@netblue30
Copy link
Owner

merged, thanks!

@netblue30 netblue30 merged commit 2a4c7a7 into netblue30:master Mar 24, 2021
@rusty-snake rusty-snake deleted the better-renames branch March 24, 2021 17:35
@glitsj16 glitsj16 mentioned this pull request Mar 24, 2021
glitsj16 added a commit that referenced this pull request Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants