Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vmware.profile & dbus-policy for amarok #4116

Merged
merged 4 commits into from
Mar 24, 2021
Merged

Update vmware.profile & dbus-policy for amarok #4116

merged 4 commits into from
Mar 24, 2021

Conversation

Neo00001
Copy link
Collaborator

should I create mkdir entry for /var/lib/vmware?

@glitsj16
Copy link
Collaborator

glitsj16 commented Mar 19, 2021

should I create mkdir entry for /var/lib/vmware?

The mkdir and mkfile options only apply to paths under ${HOME} AFAIK. It might need writable-var though

@rusty-snake
Copy link
Collaborator

manpage:

Create a directory in user home, under /tmp, or under /run/user/ before the sandbox is started.

Copy link
Collaborator

@rusty-snake rusty-snake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amarok: Did you test the tray-icon? If not it maybe needs dbus-user.own org.kde.*.
vmware: agree to @glitsj16

@Neo00001
Copy link
Collaborator Author

It might need writable-var though

should I add writable-var?

amarok: Did you test the tray-icon? If not it maybe needs dbus-user.own org.kde.*

yep.tray-icon was working smoothly.no need for dbus-user.own org.kde.*. btw tested on Arch kde, if you think other de may need this then I will add it.

@Neo00001
Copy link
Collaborator Author

should I add writable-var?

after going through there their documentation it seems write permission is needed.So adding it.

@Neo00001
Copy link
Collaborator Author

Neo00001 commented Mar 21, 2021

amarok's dbus-policy checked on gnome, will check on xfce later.Afaik, xfce's implementation is similar to gnome if not the same.

Edit: It's same for the xfce.So nothing to add. Should I merge this?

@netblue30
Copy link
Owner

Should I merge this?

Absolutely! When you are done, you just merge it.

@netblue30 netblue30 merged commit 8c1911c into netblue30:master Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants