Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document enabling debugging for Node.js #4085

Merged
merged 2 commits into from
Mar 19, 2021

Conversation

tredondo
Copy link
Contributor

No description provided.

Copy link
Collaborator

@rusty-snake rusty-snake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO the descriptions should be changed, rest LGTM.

@@ -1,5 +1,6 @@
# Firejail profile for Node.js
# Description: Common profile for npm/yarn
# Description: Asynchronous event-driven JavaScript runtime
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's nodejs-common.profile not nodejs.profile. The description is right.

$ grep nodejs-common.profile /etc/firejail/*
/etc/firejail/npm.profile:include nodejs-common.profile
/etc/firejail/yarn.profile:include nodejs-common.profile

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right now that I looked again at the profiles. So there's no specific profile for Node.js then. Should the description be "Common profile for npm, yarn and Node.js"? And maybe have a node.profile that includes it? I don't know why there's no node.profile.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So there's no specific profile for Node.js then. Should the description be "Common profile for npm, yarn and Node.js"? And maybe have a node.profile that includes it? I don't know why there's no node.profile.

Correct, we don't have node.profile (yet). A very untested example:

# Firejail profile for node
# Description: Evented I/O for V8 javascript
quiet
# This file is overwritten after every install/update
# Persistent local customizations
include node.local
# Persistent global definitions
include globals.local

# Redirect
include nodejs-common.profile

If we introduce such node.profile you could change the description of nodejs-common.profile. My Node.js experience is way too limited to judge whether that's a good idea or not.

etc/profile-m-z/nodejs-common.profile Outdated Show resolved Hide resolved
@netblue30 netblue30 merged commit 26c0319 into netblue30:master Mar 19, 2021
@netblue30
Copy link
Owner

merged, thanks!

@tredondo tredondo deleted the tredondo-nodejs branch March 28, 2021 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants