-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document enabling debugging for Node.js #4085
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO the descriptions should be changed, rest LGTM.
@@ -1,5 +1,6 @@ | |||
# Firejail profile for Node.js | |||
# Description: Common profile for npm/yarn | |||
# Description: Asynchronous event-driven JavaScript runtime |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's nodejs-common.profile not nodejs.profile. The description is right.
$ grep nodejs-common.profile /etc/firejail/*
/etc/firejail/npm.profile:include nodejs-common.profile
/etc/firejail/yarn.profile:include nodejs-common.profile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right now that I looked again at the profiles. So there's no specific profile for Node.js then. Should the description be "Common profile for npm, yarn and Node.js"? And maybe have a node.profile
that includes it? I don't know why there's no node.profile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So there's no specific profile for Node.js then. Should the description be "Common profile for npm, yarn and Node.js"? And maybe have a node.profile that includes it? I don't know why there's no node.profile.
Correct, we don't have node.profile (yet). A very untested example:
# Firejail profile for node
# Description: Evented I/O for V8 javascript
quiet
# This file is overwritten after every install/update
# Persistent local customizations
include node.local
# Persistent global definitions
include globals.local
# Redirect
include nodejs-common.profile
If we introduce such node.profile
you could change the description of nodejs-common.profile
. My Node.js experience is way too limited to judge whether that's a good idea or not.
merged, thanks! |
No description provided.