fix firecfg links in restrictive sandboxes #4007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firejail symbolic link redirection currently depends on a shell, but in restrictive sandboxes there might be no execute permission, or private-lib might have removed necessary libraries, or seccomp might block required syscalls ... Fix this by forcing --shell=none. closes netblue30#3911
smitsohu
force-pushed
the
privatelib5
branch
from
1f9886a
to
8d7974a
Compare
|
Great stuff! This should bring back some sanity to firecfg and (hopefully) diminish the number of user reported issues with it. |
|
merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firejail symbolic link redirection currently depends
on a shell, but in restrictive sandboxes there
might be no execute permission, or
private-libmighthave removed necessary libraries, or
seccompmightblock required syscalls ...
Fix this by forcing
--shell=none.Closes #3911