really fix running kernel config check #3859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archiver-common.inc includes `disable-shell.inc`, breaking $ zcat /proc/config.gz Cannot start application: Permission denied
archiver-common.inc includes `disable-shell.inc`, breaking $ zgrep -c "CONFIG_USER_NS=y" /proc/config.gz Cannot start application: Permission denied
reinerh
reviewed
Jan 1, 2021
| @@ -8,6 +8,8 @@ include zcat.local | |||
| #include globals.local | |||
|
|
|||
| # Allow running kernel config check | |||
| noblacklist ${PATH}/bash | |||
There was a problem hiding this comment.
it looks like that assumes that bash is the shell used with /bin/sh. shouldn't also other shells be allowed? because Debian uses dash as default shell for /bin/sh.
There was a problem hiding this comment.
I forgot about Debian using dash. To cover all setups it's better to ignore including disable-shell.inc IMO. Thanks for catching this! A fix is waiting for the checks to finish.
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our archiver-common.inc includes
disable-shell.inc, breaking running kernel config check with zcat or zgrep.