Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add gnome-shell search-provider file to firefox.profile #3768

Merged
merged 3 commits into from
Nov 24, 2020
Merged

add gnome-shell search-provider file to firefox.profile #3768

merged 3 commits into from
Nov 24, 2020

Conversation

glitsj16
Copy link
Collaborator

@glitsj16 glitsj16 commented Nov 22, 2020

Firefox has gnome-shell search-provider support since version 78:

Let's add a comment on how to enable this in firejail.

Firefox has gnome-shell search-provider support since version 78:
- https://bugzilla.mozilla.org/show_bug.cgi?id=1239694
- https://mastransky.wordpress.com/2020/09/25/firefox-gnome-shell-search-provider/
Let's add a comment on how to enable this in firejail.
Copy link
Collaborator

@rusty-snake rusty-snake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitelist /usr/share/gnome-shell/search-providers/firefox-search-provider.ini should work too, should it not? Then we can enable it by default IMO.

On Fedora it contains BusName=org.mozilla.Firefox.SearchProvider I'm wondering why we need no additional dbus-user.own.


OT: gnome-shell search-provider are started via D-Bus and are always unsandboxed. Even firecfg.py has only partial support for it ATM.

@glitsj16 glitsj16 changed the title add gnome-shell search-provider comment to firefox.profile add gnome-shell search-provider file to firefox.profile Nov 22, 2020
@glitsj16
Copy link
Collaborator Author

whitelist /usr/share/gnome-shell/search-providers/firefox-search-provider.ini should work too, should it not? Then we can enable it by default IMO.

@rusty-snake Yep, that's a cleaner way to do it. Thanks!

@glitsj16 glitsj16 merged commit eb3f80c into netblue30:master Nov 24, 2020
@glitsj16 glitsj16 deleted the ff-search-provider branch November 24, 2020 01:49
@matu3ba matu3ba mentioned this pull request Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants