Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update okular.profile to support cbr files #3704

Merged
merged 2 commits into from
Oct 27, 2020

Conversation

blockbandit
Copy link
Contributor

okular has support for reading cbr (rar-compressed comic book). without unrar or unar in private-bin, okular fails to decompress the files for viewing.

If your PR isn't about profiles or you have no idea how to do one of these, skip the following and go ahead with this PR.

If you make a PR for new profiles or changeing profiles please do the following:

  • The ordering of options follow the rules descripted in /usr/share/doc/firejail/profile.template.

    Hint: The profile-template is very new, if you install firejail with your package-manager, it maybe missing, therefore, and to follow the latest rules, it is recommended to use the template from the repository.

  • Order the arguments of options alphabetical, you can easy do this with the sort.py.
    The path to it depends on your distro:

    Distro Path
    Arch/Fedora /usr/lib64/firejail/sort.py
    Debian/Ubuntu/Mint /usr/lib/x86_64-linux-gnu/firejail/sort.py
    local git clone contrib/sort.py

    Note also that the sort.py script exists only since firejail 0.9.61.

See also CONTRIBUTING.md.

okular has support for reading cbr (rar-compressed comic book). without unrar or unar  in private-bin, okular fails to decompress the files for viewing.
Copy link
Collaborator

@rusty-snake rusty-snake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 can you run sort.py do sort the private-bin.

@rusty-snake rusty-snake merged commit c2f4072 into netblue30:master Oct 27, 2020
@rusty-snake
Copy link
Collaborator

thanks

@blockbandit blockbandit deleted the patch-1 branch October 27, 2020 12:59
@reinerh
Copy link
Collaborator

reinerh commented Oct 27, 2020

what about the other comic book formats?
https://en.wikipedia.org/wiki/Comic_book_archive
I would guess it also needs 7zip, tar, zip for the other archives, doesn't it?

@matu3ba matu3ba mentioned this pull request Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants