Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New profiles for balsa,trojita,kube #3603

Merged
merged 17 commits into from
Sep 3, 2020
Merged

New profiles for balsa,trojita,kube #3603

merged 17 commits into from
Sep 3, 2020

Conversation

bbhtt
Copy link
Contributor

@bbhtt bbhtt commented Aug 26, 2020

No description provided.

Copy link
Collaborator

@rusty-snake rusty-snake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  • IIRC, GPG needs writable-run-user
  • @ all, do we want GPG opt-in or opt-out?
  • whitelisting-profiles would be better since these programs heavily deal with untrusted/internet-data.

etc/profile-a-l/balsa.profile Show resolved Hide resolved
etc/profile-a-l/kube.profile Outdated Show resolved Hide resolved
@bbhtt
Copy link
Contributor Author

bbhtt commented Aug 26, 2020

1. Do they? As I checked they need the ~/.gnupg directory rw only.
2. My take is don't enable gpg by default.
3. I thought about making whitelisted...then you need to modify the existing like geary,evolution etc. add browser support+they create lot of extra folders for storing contacts,address book, in non-standard locations which I don't use...

<....>

@rusty-snake
Copy link
Collaborator

I think we should make a allow-gpg/ssh.inc …

We can't. If you put whitelist ${HOME}/.ssh in it, you break whitelisting profiles, omitting it makes it useless. Profiles without private-bin don't need it and break, profiles with it need it. . . .

@rusty-snake
Copy link
Collaborator

  1. /run/user/UID not ~/.gnupg

@bbhtt
Copy link
Contributor Author

bbhtt commented Aug 27, 2020

Do you want to switch other mail clients too on a whitelist basis? kmail,thunderbird,nylas,mutt,evolution.geary fetch/fossmail...

@rusty-snake
Copy link
Collaborator

Thunderbird is whitelisting and it would be good if the others where (commented) whitelisting profiles too. (Up for a new PR).

@bbhtt
Copy link
Contributor Author

bbhtt commented Aug 27, 2020

if the others where (commented) whitelisting profiles too

What do you mean by commented whitelisting?

@rusty-snake
Copy link
Collaborator

opt-in. IDK how much breaktage it will bring.

@bbhtt
Copy link
Contributor Author

bbhtt commented Aug 28, 2020

I can push evolution here or a separate one? The other ones I haven't/won't use now...

@rusty-snake
Copy link
Collaborator

Separate one, so we can merge it independently.

Copy link
Collaborator

@rusty-snake rusty-snake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge conflict. Please rebase or resolve it differently.

etc/profile-a-l/kube.profile Outdated Show resolved Hide resolved
etc/profile-m-z/trojita.profile Outdated Show resolved Hide resolved
@bbhtt
Copy link
Contributor Author

bbhtt commented Sep 2, 2020

Is it okay now or do I rebase? For some reason too many branches messed up by ,git/config, this was tracking a totally different branch, so, I fetched/status but couldn't find a conflict.

Copy link
Collaborator

@rusty-snake rusty-snake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest looks great.

etc/inc/disable-programs.inc Outdated Show resolved Hide resolved
etc/profile-a-l/balsa.profile Outdated Show resolved Hide resolved
@rusty-snake rusty-snake merged commit 7df28c1 into netblue30:master Sep 3, 2020
@rusty-snake
Copy link
Collaborator

Thanks for this contribution!

@bbhtt bbhtt deleted the mails branch November 11, 2020 07:50
@matu3ba matu3ba mentioned this pull request Oct 7, 2021
kmk3 added a commit that referenced this pull request Oct 1, 2024
This amends commit 7df28c1 ("New profiles for balsa,trojita,kube
(#3603)", 2020-09-03).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants