Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New profile for man,psi,smuxi; fix pidgin #3590

Merged
merged 7 commits into from
Sep 2, 2020
Merged

New profile for man,psi,smuxi; fix pidgin #3590

merged 7 commits into from
Sep 2, 2020

Conversation

bbhtt
Copy link
Contributor

@bbhtt bbhtt commented Aug 15, 2020

Will add smuxi to this PR later... Done I think...

@bbhtt bbhtt changed the title New profile for psi,smuxi; fix pidgin New profile for man,psi,smuxi; fix pidgin Aug 16, 2020
Copy link
Collaborator

@rusty-snake rusty-snake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'm not sure whether we should add man to firecfg or not. Does it break man in root shells? I mean to remember such comments in other cli profiles.

# tracelog

disable-mnt
# Add "gpg,gpg2,gpg-agent,pinentry,pinentry-gtk-2" for GPG
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depending on DE other pinentry binaries are needed. Is pinentry for all distros a symlink? if so, the default binary is copied.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a symlink for me on Arch...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add more pinentry binaries.

Copy link
Contributor Author

@bbhtt bbhtt Aug 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anything other than this?

pinentry-curses
pinentry-fltk
pinentry-gnome3
pinentry-gtk2 or pinentry-gtk-2
pinentry-qt
pinentry-qt4
pinentry-tty
pinentry-x2go
pinentry-kwallet 

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pinentry-gtk and pinentry-emacs(?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a gtk; emacs one I forgot...

@bbhtt
Copy link
Contributor Author

bbhtt commented Aug 25, 2020

Does it break man in root shells?

Working for me when I set a symlink using firecfg. su > /usr/local/bin/man man...

I'm not sure whether we should add man to firecfg or not.

Keep the profile and comment it in firecfg, people who want it can use; finding the bins wasn't easy... half of them never came up in strace or build, had to look through man bug reports...

etc/profile-m-z/psi.profile Outdated Show resolved Hide resolved
@rusty-snake rusty-snake merged commit c542881 into netblue30:master Sep 2, 2020
@rusty-snake
Copy link
Collaborator

Thanks for this contribution!

@bbhtt bbhtt deleted the xmpp branch September 2, 2020 13:34
@matu3ba matu3ba mentioned this pull request Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants