Allow google-chrome access to the custom flags files in ~/.config. #3418
Conversation
|
Nice catch! It would be nice if you could keep the PR conform our current google-chrome profiles. I'll try to explain what I mean below. In disable-programs.inc add: Use the noblacklist/mkfile option in google-chrome.profile above the whitelisting: mkfile ${HOME}/.config/chrome-flags.conf Also, this needs to be done for google-chrome-beta.profile and google-chrome-unstable.profile too. This all means a bit of extra work, sorry about that :-) |
I'm not sure, but if they are created by the user and not by chrome, we don't need mkfile. |
Not sure if google-chrome creates these. Never used google-chrome. But @mace015 should be able to figure that out I guess, and follow your advise accordingly. |
|
Neither google-chrome nor chromium create these files, they are not needed for both to function either, should I include that anyway? The chromium profile also doesn't implement |
@mace015 Thanks for confirming that. We do want to support these custom flags if they exist. So the only thing you can drop are the |
…a and google-chrome-unstable.
…le to the disable-programs.inc list.
|
I've updated the PR, thanks for helping me out with this! If there is anything I should change please let me know! |
| @@ -8,10 +8,16 @@ include globals.local | |||
| noblacklist ${HOME}/.cache/google-chrome-beta | |||
| noblacklist ${HOME}/.config/google-chrome-beta | |||
|
|
|||
| noblacklist ${HOME}/.config/chrome-beta-flags.conf | |||
There was a problem hiding this comment.
We should keep the file names of the flags configuration cfr. what you used in google-chrome.profile. I'm pretty sure the beta version will otherwise not be able to find those (even when they exist). So just drop the '-beta' part. Same goes for the whitelists and the unstable profile. I'll mark those as well, just so you know where to edit.
There was a problem hiding this comment.
I've tested the profiles as they are now and google-chrome-beta does seem to look for chrome-beta-flags.conf / chrome-beta-flags.config.
| mkdir ${HOME}/.cache/google-chrome-beta | ||
| mkdir ${HOME}/.config/google-chrome-beta | ||
| whitelist ${HOME}/.cache/google-chrome-beta | ||
| whitelist ${HOME}/.config/google-chrome-beta | ||
|
|
||
| whitelist ${HOME}/.config/chrome-beta-flags.conf |
There was a problem hiding this comment.
I've tested the profiles as they are now and google-chrome-beta does seem to look for chrome-beta-flags.conf / chrome-beta-flags.config.
| @@ -8,10 +8,16 @@ include globals.local | |||
| noblacklist ${HOME}/.cache/google-chrome-unstable | |||
| noblacklist ${HOME}/.config/google-chrome-unstable | |||
|
|
|||
| noblacklist ${HOME}/.config/chrome-unstable-flags.conf | |||
There was a problem hiding this comment.
I've tested the profiles as they are now and google-chrome-unstable does seem to look for chrome-unstable-flags.conf / chrome-unstable-flags.config.
| mkdir ${HOME}/.cache/google-chrome-unstable | ||
| mkdir ${HOME}/.config/google-chrome-unstable | ||
| whitelist ${HOME}/.cache/google-chrome-unstable | ||
| whitelist ${HOME}/.config/google-chrome-unstable | ||
|
|
||
| whitelist ${HOME}/.config/chrome-unstable-flags.conf |
There was a problem hiding this comment.
I've tested the profiles as they are now and google-chrome-unstable does seem to look for chrome-unstable-flags.conf / chrome-unstable-flags.config.
This PR modifies the google-chrome.profile to allow chrome access to its custom flag files in ~/.config.