Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove nodbus from MPRIS client profiles #2384

Merged
merged 1 commit into from
Feb 1, 2019
Merged

remove nodbus from MPRIS client profiles #2384

merged 1 commit into from
Feb 1, 2019

Conversation

carloabelli
Copy link
Contributor

MPRIS is a D-Bus interface for controlling media players. The nodbus
option prevents these players from being controlled through MPRIS.
It seems that most of the other media players did not have the nodbus
option or it was already commented out.

@carloabelli carloabelli changed the title remove nodbus from MPRIS clients remove nodbus from MPRIS client profiles Feb 1, 2019
@Vincent43
Copy link
Collaborator

@carloabelli could you add comment above nodbus option that it conflicts with MPRIS?

MPRIS is a D-Bus interface for controlling media players. The nodbus
option prevents these players from being controlled through MPRIS.
It seems that most of the other media players did not have the nodbus
option or it was already commented out.
@carloabelli
Copy link
Contributor Author

@Vincent43 done

@carloabelli
Copy link
Contributor Author

I could also add nodbus comments for other application profiles that use MPRIS, but did not have nodbus listed. Right now I only added it for those I could find that already had a nodbus line.

@Vincent43 Vincent43 merged commit 5ef4b01 into netblue30:master Feb 1, 2019
@carloabelli carloabelli deleted the mpris branch February 22, 2019 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants