Enumerate root directories in apparmor profile #1587
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace opaque character class with an explicit list of root-level directories to be granted access.
The replaced line in the apparmor profile deceptively granted access to all root-level directories that did not start with the letters any of the characters
coprsy,^
, which is probably not what was intended.Once apparmor supports the proposed addition, this line can be replaced with
{**^sys,proc}
, which is what (I am guessing) was intended.I'm currently running with this rule loaded. Other tools may need more liberal permissions. Notice that this adds access to
opt
andsrv
, which previously would not have been whitelisted.