Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

${HOME} and ~ not supported in netfilter file name #6032

Closed
michelesr opened this issue Oct 3, 2023 · 0 comments · Fixed by #6109
Closed

${HOME} and ~ not supported in netfilter file name #6032

michelesr opened this issue Oct 3, 2023 · 0 comments · Fixed by #6109
Labels
enhancement New feature request
Projects
Release 0.9.74

Comments

@michelesr
Copy link
Contributor

Description

${HOME} and ~ don't expand in the netfilter file name in a profile. It works when passed as cli argument --netfilter=~/somefile.

Error: invalid network filter file ~/somefile

While passing those paths in the cli with --netfilter=${HOME}/somefile or--netfilter=${HOME}/somefile

Steps to Reproduce

  1. create a profile with netfilter ~/somefile of netfilter ${HOME}/somefile
  2. run firejail with that profile

Expected behavior

The netfilter profile is loaded.

Actual behavior

Error: invalid network filter file ~/somefile

Environment:

  • firejail version 0.9.72
  • Arch Linux
@rusty-snake rusty-snake added the enhancement New feature request label Oct 7, 2023
@kmk3 kmk3 added this to To do in Release 0.9.74 via automation Nov 27, 2023
kmk3 added a commit to kmk3/firejail that referenced this issue Nov 27, 2023
@kmk3
feature: expand simple macros in more commands
e69c1df 
This includes macros such as `${HOME}` and `${RUNUSER}`.

Commands:

* --chroot=
* --netfilter=
* --netfilter6=
* --trace=

Closes netblue30#6032.

Reported-by: @michelesr
@kmk3 kmk3 mentioned this issue Nov 27, 2023
Merged
@kmk3 kmk3 moved this from To do to In progress in Release 0.9.74 Nov 27, 2023
kmk3 added a commit that referenced this issue Jan 4, 2024
@kmk3
RELNOTES: add feature items
796c93d 
Relates to #2097 #5876 #6032 #6078 #6109 #6115 #6125.
@kmk3 kmk3 moved this from In progress to Done (on RELNOTES) in Release 0.9.74 Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature request
Projects
Release 0.9.74
  
Done (on RELNOTES)
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feature: expand simple macros in more commands kmk3/firejail
2 participants
@michelesr @rusty-snake