Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement] Print better error in the case of ownership issues #2743

Closed
chiraag-nataraj opened this issue Jun 3, 2019 · 3 comments
Closed
Labels
enhancement New feature request

Comments

@chiraag-nataraj
Copy link
Collaborator

If I use private-bin to whitelist a binary in /usr/bin which happens to have the wrong owner (for example, my user), firejail prints a very opaque and unhelpful error. The context this came up in is protonmail-bridge, which (for some godforsaken reason) installed with my user as the owner (going to report that as a bug to them). This meant that private-bin failed (as it should), but the error message was unhelpful in figuring out what the problem was.

@chiraag-nataraj chiraag-nataraj added the enhancement New feature request label Jun 3, 2019
@rusty-snake
Copy link
Collaborator

If we want to print better error messages, we can also fix this:

$ firejail --name  # Invalid because it need =NAME
Error: invalid --name command line option
$ firejail --doesnt_exists # Invalid because it doesn't exists
Error: invalid --doesnt_exists command line option

@rusty-snake
Copy link
Collaborator

or this (--quiet and --debug):

$ firejail --quiet --debug XXX # or firejail --debug --quiet
Error: invalid --debug command line option

@netblue30
Copy link
Owner

Closed for now, any other problem go to #4275

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature request
Projects
None yet
Development

No branches or pull requests

3 participants