Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building from git broken on Arch Linux after recent apparmor-related commits #1750

Closed
glitsj16 opened this issue Jan 25, 2018 · 3 comments
Closed
Labels
bug Something isn't working

Comments

@glitsj16
Copy link
Collaborator

Building from git master is currently broken on Arch Linux. I usually keep up with git master pretty close, but have been out a few days so I'm not sure which exact commit(s) are responsible for this breakage. I assume it might be something in the recent apparmor-related commits. On Ubuntu things are fine, as that has apparmor in its default repositories. But Arch Linux doesn't and this hasn't been a problem before.

Full configure/make output available.

The below make output stays exactly the same, no matter whether configuring with only --prefix=/usr (the default), adding --disable-apparmor or --enable-apparmor=no:

$ make
make -C src/lib
make[1]: Entering directory '/home/glitsj16/.buildzone/00.tmpfs/firejail/src/lib'
make[1]: Nothing to be done for 'all'.
make[1]: Leaving directory '/home/glitsj16/.buildzone/00.tmpfs/firejail/src/lib'
make -C src/firejail
make -C src/firemon
make -C src/fsec-print
make[1]: Entering directory '/home/glitsj16/.buildzone/00.tmpfs/firejail/src/firemon'
gcc -ggdb -O2 -DVERSION='"0.9.53"' -DPREFIX='"/usr"' -fstack-protector-all -D_FORTIFY_SOURCE=2 -fPIE -pie -Wformat -Wformat-security -c apparmor.c -o apparmor.o
make[1]: Entering directory '/home/glitsj16/.buildzone/00.tmpfs/firejail/src/fsec-print'
make[1]: Nothing to be done for 'all'.
make[1]: Leaving directory '/home/glitsj16/.buildzone/00.tmpfs/firejail/src/fsec-print'
make[1]: Entering directory '/home/glitsj16/.buildzone/00.tmpfs/firejail/src/firejail'
make[1]: Nothing to be done for 'all'.
make[1]: Leaving directory '/home/glitsj16/.buildzone/00.tmpfs/firejail/src/firejail'
make -C src/fsec-optimize
make -C src/firecfg
make[1]: Entering directory '/home/glitsj16/.buildzone/00.tmpfs/firejail/src/fsec-optimize'
gcc -ggdb -O2 -DVERSION='"0.9.53"' -DPREFIX='"/usr"' -DSYSCONFDIR='"/etc/firejail"' -DLIBDIR='"/usr/lib"' -DHAVE_X11 -DHAVE_PRIVATE_HOME -DHAVE_OVERLAYFS -DHAVE_SECCOMP -DHAVE_GLOBALCFG -DHAVE_SECCOMP_H -DHAVE_CHROOT -DHAVE_NETWORK -DHAVE_USERNS -DHAVE_BIND -DHAVE_FILE_TRANSFER -DHAVE_WHITELIST -fstack-protector-all -D_FORTIFY_SOURCE=2 -fPIE -pie -Wformat -Wformat-security -c main.c -o main.o
make[1]: Entering directory '/home/glitsj16/.buildzone/00.tmpfs/firejail/src/firecfg'
gcc -ggdb -O2 -DVERSION='"0.9.53"' -DPREFIX='"/usr"' -DSYSCONFDIR='"/etc/firejail"' -DLIBDIR='"/usr/lib"' -DHAVE_X11 -DHAVE_SECCOMP -DHAVE_SECCOMP_H -DHAVE_CHROOT -DHAVE_NETWORK -DHAVE_USERNS -DHAVE_BIND -DHAVE_FILE_TRANSFER -fstack-protector-all -D_FORTIFY_SOURCE=2 -fPIE -pie -Wformat -Wformat-security -c desktop_files.c -o desktop_files.o
apparmor.c:21:10: fatal error: sys/apparmor.h: No such file or directory
#include <sys/apparmor.h>
^~~~~~~~~~~~~~~~
compilation terminated.
make[1]: *** [Makefile:23: apparmor.o] Error 1
make[1]: Leaving directory '/home/glitsj16/.buildzone/00.tmpfs/firejail/src/firemon'
make: *** [Makefile:35: src/firemon] Error 2

Regards

@SkewedZeppelin SkewedZeppelin added the bug Something isn't working label Jan 26, 2018
@Fred-Barclay
Copy link
Collaborator

Thanks, yes, this was introduced in 5ebebb1 (according to my testing). I've pinged @netblue30 with a comment; hopefully we can get it sorted soon. 😄

I did have trouble even when building on Ubuntu 17.10, though.
Cheers!
Fred

netblue30 pushed a commit that referenced this issue Jan 26, 2018
@netblue30
Copy link
Owner

Fixed, thanks!

@Fred-Barclay
Copy link
Collaborator

Thanks @glitsj16 and @netblue30! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants