Skip to content

Commit

Permalink
Make nogroups work on nvidia again
Browse files Browse the repository at this point in the history
Remove workaround from commit 623e682 ("temporary fix for
nvidia/nogroups/noroot issue (#3644, #841)", 2020-10-02) and from commit
cb460c3 ("more nvidia (#3644)", 2020-10-03).

The handling of the "render" and "video" groups is separate from
`nogroups` now, so disabling `nogroups` on nvidia shouldn't be necessary
anymore.  See the previous 2 commits for details.

See also the discussion on PR #4632.
  • Loading branch information
kmk3 committed Nov 30, 2021
1 parent a72f536 commit 6ddedeb
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions src/firejail/profile.c
Original file line number Diff line number Diff line change
Expand Up @@ -416,13 +416,7 @@ int profile_check_line(char *ptr, int lineno, const char *fname) {
return 0;
}
else if (strcmp(ptr, "nogroups") == 0) {
// nvidia cards require video group; disable nogroups
if (access("/dev/nvidiactl", R_OK) == 0 && arg_no3d == 0) {
fwarning("Warning: NVIDIA card detected, nogroups command disabled\n");
arg_nogroups = 0;
}
else
arg_nogroups = 1;
arg_nogroups = 1;
return 0;
}
else if (strcmp(ptr, "nosound") == 0) {
Expand Down

0 comments on commit 6ddedeb

Please sign in to comment.