fix(core): when using forward references on exports
array
#13712
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
the following code triggers the error because of the
forwardRef
onexports
arrayWhich breaks the
ConditionModule
from@nestjs/config
when we use a forward reference.Do note that the same error happens when we supply a promise to
exports
:but I didn't address this error in this PR because I'm not sure about the error handling for rejected promises and about the right place to resolve such promise.
What is the new behavior?
we can now use
forwardRef
onexports
, as its type definition tell us so.I also made a tiny change to the issue template of bug reports. It will look like this:
Does this PR introduce a breaking change?
Other information
I guess such usage was supposed to be supported since this commit: 0fcdf4e