Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add notice about closing unreproducible issues to bug report issue template #12774

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

micalevisk
Copy link
Member

@micalevisk micalevisk commented Nov 19, 2023

A minor change to the bug report issue template form to better align with contributions expectations. I'm using this great article to clarify why we need a reproduction. This is my attempt to decrease the amount of bugs report without reproductions when they clearly need one

then

image

now

image

@micalevisk
Copy link
Member Author

@jmcdo29 can you review the wording here? I tried to not sound rude/discouraging

@coveralls
Copy link

coveralls commented Nov 19, 2023

Pull Request Test Coverage Report for Build fde6c655-5250-4787-aa5f-d01d950b4fc0

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.254%

Totals Coverage Status
Change from base Build 555bbd68-1512-4fcc-97ea-c841f60dea7e: 0.0%
Covered Lines: 6693
Relevant Lines: 7255

💛 - Coveralls

Copy link
Member

@jmcdo29 jmcdo29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine. Maybe change "didn't" to "don't", but it reads fine and comes off as a warning without being hostile

@kamilmysliwiec kamilmysliwiec merged commit 30ce4b4 into nestjs:master Nov 20, 2023
5 checks passed
@kamilmysliwiec
Copy link
Member

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants