Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add Missing WorkerOptions types on BullQueueAdvancedProcessor and BullQueueAdvancedSeparateProcessor #2124

Merged

Conversation

ivannalon
Copy link
Contributor

@ivannalon ivannalon commented Jun 13, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe: Add missing types

What is the current behavior?

closes #1971

Issue Number: N/A

What is the new behavior?

Now the BullQueueAdvancedProcessor and BullQueueAdvancedSeparateProcessor extends WorkerOptions interface adding additional options.

WorkerOptions interface: https://github.com/taskforcesh/bullmq/blob/b28981938e8a4504905363551544633d9734e20f/src/interfaces/worker-options.ts#L16

Does this PR introduce a breaking change?

  • Yes
  • No

@VirtualPirate
Copy link

VirtualPirate commented Jun 21, 2024

I wanted to use Worker Threads, since the default option is sandboxed processors. I can't pass the option of {useWorkerthreads: true} through this @nestjs/bullmq package.

This PR will fix this issue

Copy link
Member

@micalevisk micalevisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but do notice that if bullmq team want to add some property on that WorkerOptions type that will overwrite the ones at our side, we'll have to change this file to exclude them

@kamilmysliwiec kamilmysliwiec merged commit bf81653 into nestjs:master Jul 2, 2024
1 check passed
@kamilmysliwiec
Copy link
Member

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing WorkerOptions types on BullQueueAdvancedProcessor and BullQueueAdvancedSeparateProcessor
4 participants