Update models with adaptation mechanisms and change tag 'adaptive threshold' to 'adaptation' #3241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessica-mitchell
added
S: Normal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the model tag for models that use an adaptation mechanism to 'adaptation' after discussions with @ddahmen
The reason is that not all the models have the same adaptation mechanism, and the ones labeled with adaptive threshold (i.e. 'aeif' models) technically do not have an adaptive threshold.
We were also missing tags for several models that have an adaptation mechanism but were not 'aeif' models.
See Read the Docs output here: https://nest-simulator--3241.org.readthedocs.build/en/3241/models/index.html#adaptation
@shimoura agreed to review, thanks!