-
-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
S7 Scheme language support #2113
Conversation
…have better error handling
Please make all the builds passed https://github.com/nesbox/TIC-80/actions/runs/4074721024 |
@nesbox I'm having a hard time with the rpi-baremetal and n3ds platforms with those jmp issues. I need to distinguish those platforms so that I can get them to use the other set of jmps definitions but I don't know how to. Is there any macros that you know that would distinguish them? Thanks! |
…mpt at fix n3ds and baremetal targets.
Try something like #if defined(BAREMETALPI) || defined(_3DS)
#endif Line 27 in b62be5f
|
and... nope! but maybe those need to be included from somewhere... I'll look more in details tonight. At least, IO should be officially disabled now :) |
… attempt at compiling n3ds/baremetal targets
…k issue was a name clash with the api's scheme.c file.
okay, I need more help. I managed to make all the targets compile, but there remains this link issue on baremetalpi that I have no clue why it's happening. It seems that the (now renamed) libs7scheme.a lib doesn't get linked properly with libtic80core for some reason... :( Can anyone help me? |
@sogaiu omg, you're a genius! hehe I didn't know that the baremetal target had it's own makefile... |
i'm noticing that Janet and Scheme would probably be need to be added to the export-stub actions once they make it fully into the version. |
Yes, pls add TIC-80/.github/workflows/build.yml Line 688 in b62be5f
|
I don't know why this would fail, I simply added scheme to the workflow list. Was there more to do? I don't know much about github workflows... |
ok i think we're good to go! |
Everything looks good now and I'm going to merge it, one thing could you please make BTW, pls don't forget add yourself to the Credits page https://github.com/nesbox/TIC-80#credits |
I wanted to use s7 as a submodule, but I wasn't able to clone their git repo (it's hosted in the Standford university gitlabs https://cm-gitlab.stanford.edu/bil/s7). I also had to edit it to disable io and make it compile on some targets, so we're not on sync with them. I will try to get my changes merged up and see if they can make their repo more accessible. I would love to continue contributing to tic80, I'm having a ton of fun. I have a few questions about that:
Thanks! |
Usually, we discuss changes directly in the Issues.
You already put the option to theme config and main menu in your PR :) there is no better place for it |
These changes add scheme support to tic-80